Artix Linux Forum

Artix Linux => Package management => Topic started by: cr6 on 30 April 2024, 19:19:02

Title: mpg123 config is wrong
Post by: cr6 on 30 April 2024, 19:19:02
Hi,

Looking at the mpg123 PKGBUILD (https://gitea.artixlinux.org/packages/mpg123/src/branch/master/PKGBUILD#L29) ...

Code: [Select]
./configure \
  --enable-int-quality

However such an option does not exist!

Code: [Select]
$ ./configure --help
[...]
  --disable-messages      no error/warning messages on the console
  --enable-runtime-tables calculate tables at runtime saving size at the
                          expense of additional computation at load time
  --disable-new-huffman   new huffman decoding scheme by Taihei (faster on
                          modern CPUs at least, so on by default)
  --disable-int-quality   use rounding instead of fast truncation for integer
                          output, where possible
  --disable-16bit         no 16 bit integer output
  --disable-8bit          no 8 bit integer output
  --disable-32bit         no 32 bit integer output (also 24 bit)
  --disable-real          no real (floating point) output
[...]

Only "--disable-int-quality" is proposed.  :-\  ::)
Title: Re: mpg123 config is wrong
Post by: ####### on 30 April 2024, 20:27:55
I think it's probably valid being the inverse, I'd guess it is written like that in --help to indicate which is the default but it might be explicitly specified due to the default having changed in the past, or likely to change in future:
https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Package-Options.html (https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Package-Options.html)
And these sort of issues often originate from the Arch Linux PKGBUILD as does this one, so that would be the place to report it:
https://gitlab.archlinux.org/archlinux/packaging/packages/mpg123/-/blob/main/PKGBUILD?ref_type=heads (https://gitlab.archlinux.org/archlinux/packaging/packages/mpg123/-/blob/main/PKGBUILD?ref_type=heads)
Most likely it's just wasting a few bytes in the PKGBUILD, don't know for sure though, you should probably investigate further before reporting it.