Skip to main content ↑ ↓
Topic: Best Way to Contribute Bug Fix? (Read 616 times) previous topic - next topic
0 Members and 3 Guests are viewing this topic.

Best Way to Contribute Bug Fix?

I recently fixed a bug that's been bothering me for a while in the tailscale-openrc package. What would be the best way for me to submit a PR/diff for this fix?

I see that the package source is mirrored on the Aritx Gitea instance. Is the suggested submission path to register an account on that federated instance and create a corresponding PR? Thanks in advance.

Re: Best Way to Contribute Bug Fix?

Reply #1 –
I suppose, you may just post your variant of the init script here on the forum. It should be a rather short sheet, shouldn't it? I've done a similar thing regarding a runit script a while ago. The devs usually react to such postings and accept reasonable fixes. You see, the atmosphere here in the Artix community is a little bit informal (which I do appreciate).
 

Re: Best Way to Contribute Bug Fix?

Reply #2 –
Yes, you can post your fix here (with a description of what it actually fixes) and we'll adopt it.

Re: Best Way to Contribute Bug Fix?

Reply #3 –
Quote from: nous – on
Yes, you can post your fix here (with a description of what it actually fixes) and we'll adopt it.

Great, that simplifies things! Here's a diff of the fix, taken from the latest Gentoo version of the script:

Code: [Select]
diff --git a/tailscaled b/tailscaled
index fb26fc1..d68e3c8 100644
--- a/tailscaled
+++ b/tailscaled
@@ -5,7 +5,7 @@
 name="tailscaled"
 description="Tailscale node agent"
 command=/usr/bin/tailscaled
-command_args="--state=/run/tailscale/tailscaled.state --socket=/run/tailscale/tailscaled.sock --port ${tailscaled_port:-41641} ${tailscaled_args}"
+command_args="--state=/var/lib/tailscale/tailscaled.state --socket=/run/tailscale/tailscaled.sock --port ${tailscaled_port:-41641} ${tailscaled_args}"
 supervisor=supervise-daemon

 depend() {

Telling tailscaled to use a /var/lib/ path for its state instead of a /run/ path ensures that it persists between boots. This allows a machine's Tailscale client to cache authentications; otherwise (as with the old implementation), the user needs to perform a web-based OAUTH on each reboot.

Re: Best Way to Contribute Bug Fix?

Reply #4 –
Bumping this in case it fell off the radar. Let me know if there's any additional details regarding the fix that I should add!